Commodore 128 for the MiSTer?

User avatar
ericgus09
Posts: 206
Joined: Mon May 25, 2020 2:47 am
Has thanked: 7 times
Been thanked: 26 times

Re: Commodore 128 for the MiSTer?

Unread post by ericgus09 »

Thanks for the info and updates.. !
rhester72
Top Contributor
Posts: 1101
Joined: Thu Jun 11, 2020 2:31 am
Has thanked: 13 times
Been thanked: 169 times

Re: Commodore 128 for the MiSTer?

Unread post by rhester72 »

Just got a chance to try this core for the first time - and even PITA C128 titles like I Am the C128 seem to work! Badass!

Sorry for such an ignorant question, but how do I flip to the 80-column display?
User avatar
NML32
Posts: 288
Joined: Sun May 24, 2020 6:57 pm
Has thanked: 272 times
Been thanked: 43 times

Re: Commodore 128 for the MiSTer?

Unread post by NML32 »

rhester72 wrote: Sat Nov 26, 2022 2:07 pm Just got a chance to try this core for the first time - and even PITA C128 titles like I Am the C128 seem to work! Badass!

Sorry for such an ignorant question, but how do I flip to the 80-column display?
There is a Keyboard image on Github that shows the key to press to toggle 40/80 column.
https://github.com/eriks5/C128_MiSTer

Press the Print Screen or Right ALT + F7 to toggle 40/80
Then reset the core.
rhester72
Top Contributor
Posts: 1101
Joined: Thu Jun 11, 2020 2:31 am
Has thanked: 13 times
Been thanked: 169 times

Re: Commodore 128 for the MiSTer?

Unread post by rhester72 »

I see that, thank you!

One other issue I'm having that I'm not quite sure what's going on - regardless of the VDC palette I choose, I seem to have my choice of different levels of grayscale (on HDMI output)...can't seem to get color at all. Is that a known issue or am I doing something wrong?

EDIT: This only happens on boot, it seems. DesTerm 128 looks fantastic!
rhester72
Top Contributor
Posts: 1101
Joined: Thu Jun 11, 2020 2:31 am
Has thanked: 13 times
Been thanked: 169 times

Re: Commodore 128 for the MiSTer?

Unread post by rhester72 »

Also, @eriks5, is it reasonable to assume you do *not* yet want bug reports? (FYI, REU _does_ work in C128 mode!)
eriks5
Core Developer
Posts: 79
Joined: Sat May 21, 2022 11:51 am
Has thanked: 38 times
Been thanked: 182 times
Contact:

Re: Commodore 128 for the MiSTer?

Unread post by eriks5 »

NML32 wrote: Sat Nov 26, 2022 2:35 pm Press the Print Screen or Right ALT + F7 to toggle 40/80
Then reset the core.
No need to reset the core, hitting END+F11 (which is RUN/STOP+RESTORE) is enough, just like on the real thing.

The C128 kernal only checks the 40/80 column switch state at reset or when you hit RUN/STOP+RESTORE
eriks5
Core Developer
Posts: 79
Joined: Sat May 21, 2022 11:51 am
Has thanked: 38 times
Been thanked: 182 times
Contact:

Re: Commodore 128 for the MiSTer?

Unread post by eriks5 »

rhester72 wrote: Sat Nov 26, 2022 2:37 pm One other issue I'm having that I'm not quite sure what's going on - regardless of the VDC palette I choose, I seem to have my choice of different levels of grayscale (on HDMI output)...can't seem to get color at all. Is that a known issue or am I doing something wrong?
Strange. Color works fine for me on HDMI and I haven't received any other report of this since the first release that had the VDC in it back in June. Could be because of the wonky timing the VDC is currently generating making it incompatible with your screen. The VDC is still very much a work in progress. And honestly it might never get 100% compatible with the real chip as that thing is buggy af and there's all sorts of weird undocumented behaviour.
rhester72 wrote: Sat Nov 26, 2022 6:31 pm Also, @eriks5, is it reasonable to assume you do *not* yet want bug reports? (FYI, REU _does_ work in C128 mode!)
I knew about the REU working, forgot to update the README for that. Done that now. Thanks

Any bug reports for stuff listed in the README as implemented are welcome. All known issues are in the README, or tickets on GitHub (but no issues there atm).

Please report issues on GitHub, so I can keep track of it, and others can see it's a known issue.
eriks5
Core Developer
Posts: 79
Joined: Sat May 21, 2022 11:51 am
Has thanked: 38 times
Been thanked: 182 times
Contact:

Re: Commodore 128 for the MiSTer?

Unread post by eriks5 »

nvm..
User avatar
ericgus09
Posts: 206
Joined: Mon May 25, 2020 2:47 am
Has thanked: 7 times
Been thanked: 26 times

Re: Commodore 128 for the MiSTer?

Unread post by ericgus09 »

Can you flip/flop between the VIC chip output and the VDC output? .. some games support dual screen .. was curious if this is supported.. maybe I missed it. Im not talking at boot/start but during running ..
eriks5
Core Developer
Posts: 79
Joined: Sat May 21, 2022 11:51 am
Has thanked: 38 times
Been thanked: 182 times
Contact:

Re: Commodore 128 for the MiSTer?

Unread post by eriks5 »

ericgus09 wrote: Sun Nov 27, 2022 3:58 am Can you flip/flop between the VIC chip output and the VDC output?
Yes, it's in the README
User avatar
ericgus09
Posts: 206
Joined: Mon May 25, 2020 2:47 am
Has thanked: 7 times
Been thanked: 26 times

Re: Commodore 128 for the MiSTer?

Unread post by ericgus09 »

eriks5 wrote: Sun Nov 27, 2022 7:06 am
ericgus09 wrote: Sun Nov 27, 2022 3:58 am Can you flip/flop between the VIC chip output and the VDC output?
Yes, it's in the README
Ok thank you .. guess I did miss it ..
User avatar
Goingdown
Posts: 38
Joined: Mon May 25, 2020 6:58 am
Has thanked: 5 times
Been thanked: 4 times

Re: Commodore 128 for the MiSTer?

Unread post by Goingdown »

I played Eye of Beholder recently with this core. Works very well (including mouse and turbo mode). I saved to disk, did not try saving to flash cart, probably does not work because c64 core does not support crt saves either.

Only thing which does not seem to work is 80 column mode for automap, there is no picture when switching to VDC? It would be nice to have simultaneous VIC and VDC outputs, but that would require two monitors. And with one monitor, switching between VIC and VDC is slower anyway than using M for map.

eriks5
Core Developer
Posts: 79
Joined: Sat May 21, 2022 11:51 am
Has thanked: 38 times
Been thanked: 182 times
Contact:

Re: Commodore 128 for the MiSTer?

Unread post by eriks5 »

Goingdown wrote: Wed Dec 14, 2022 6:47 am

Only thing which does not seem to work is 80 column mode for automap, there is no picture when switching to VDC? It would be nice to have simultaneous VIC and VDC outputs, but that would require two monitors. And with one monitor, switching between VIC and VDC is slower anyway than using M for map.

They use the 40 column mode of the VDC for that, which was not implemented. I implemented it recently along with some other missing VDC modes like interlace, and it will work in the next release. The 40-column mode fix is already on github in the 'vdc' branch, if you can build cores yourself you can get it from there. Not releasing that version yet as there are some other (exotic) VDC modes like FLI not working properly.

eriks5
Core Developer
Posts: 79
Joined: Sat May 21, 2022 11:51 am
Has thanked: 38 times
Been thanked: 182 times
Contact:

Re: Commodore 128 for the MiSTer?

Unread post by eriks5 »

New development/test release of the C128 core is here!

Changes in this release compared to the last dev release:

  • More development on the VDC to improve compatibility
  • Fixed some bugs
  • Synced with changes in upstream C64 core

The VDC should now be compatible with all official/documented modes (including 40 columns and interlace) and most undocumented ones as well. There are still some issues with very high resolution interlaced non-standard graphics modes. On some non-standard interlace modes it's the MiSTer's scaler that's freaking out, not sure if that's an issue with the core, or a bug in the scaler.

Eye of the Beholder's second screen now works. And if you want to see the core's VDC implementation really shine, try this demo: Risen from Oblivion VDC V2

In the attachment you'll find the .rbf for the core, and a modified MiSTer main binary because the core needs changes to that for the 157x changes. Disk I/O won't work without the modified main binary. The provided main binary is up-to-date with the latest changes as well. See my previous post on how to update your MiSTer main binary.

Attachments
C128-dev-release-20230121-1.zip
(2.99 MiB) Downloaded 302 times
rhester72
Top Contributor
Posts: 1101
Joined: Thu Jun 11, 2020 2:31 am
Has thanked: 13 times
Been thanked: 169 times

Re: Commodore 128 for the MiSTer?

Unread post by rhester72 »

@ericks5 Can you describe the process for getting a JiffyDOS 1571 ROM working and what the md5sum should be?

Mine is 32,768 bytes with a md5sum of 41c6cc528e9515ffd0ed9b180f8467c0 and a name of drive-jd.R71 with /media/fat/config/C128.f4 pointed to it, but the drive ID on status query is consistently "CBM DOS V3.0 1571". JiffyDOS in the system kernel works just fine.

Also, my attempt get a 1581 JiffyDOS ROM going (md5sum 20b6885c6dc2d42c38754a365b043d71, named drive-jd.r81) was interesting in the sense that once selected, it overwrote the contents of C128.f4...does that mean only one drive or the other can have an alternate ROM configured?

breiztiger
Top Contributor
Posts: 427
Joined: Sun May 24, 2020 7:17 pm
Has thanked: 22 times
Been thanked: 93 times

Re: Commodore 128 for the MiSTer?

Unread post by breiztiger »

@ericks5 can you integrate your mod for floppy in the last main MiSTer please

hdr and other ini change are not include

thanks for your work on the c128 core !!!

CPC-Power Staff
eriks5
Core Developer
Posts: 79
Joined: Sat May 21, 2022 11:51 am
Has thanked: 38 times
Been thanked: 182 times
Contact:

Re: Commodore 128 for the MiSTer?

Unread post by eriks5 »

breiztiger wrote: Sat Jan 21, 2023 2:11 pm

@ericks5 can you integrate your mod for floppy in the last main MiSTer please

hdr and other ini change are not include

thanks for your work on the c128 core !!!

Whoops.. merged the changes but didn't pull them :lol: I'll fix the original zip

edit Original post updated with a new zip

eriks5
Core Developer
Posts: 79
Joined: Sat May 21, 2022 11:51 am
Has thanked: 38 times
Been thanked: 182 times
Contact:

Re: Commodore 128 for the MiSTer?

Unread post by eriks5 »

rhester72 wrote: Sat Jan 21, 2023 2:08 pm

@ericks5 Can you describe the process for getting a JiffyDOS 1571 ROM working and what the md5sum should be?

Mine is 32,768 bytes with a md5sum of 41c6cc528e9515ffd0ed9b180f8467c0 and a name of drive-jd.R71 with /media/fat/config/C128.f4 pointed to it, but the drive ID on status query is consistently "CBM DOS V3.0 1571". JiffyDOS in the system kernel works just fine.

Probably a bug. What you're doing sounds correct.

rhester72 wrote: Sat Jan 21, 2023 2:08 pm

Also, my attempt get a 1581 JiffyDOS ROM going (md5sum 20b6885c6dc2d42c38754a365b043d71, named drive-jd.r81) was interesting in the sense that once selected, it overwrote the contents of C128.f4...does that mean only one drive or the other can have an alternate ROM configured?

Yes, right now you can only customize the rom for one of the drive types at a time. Any change will overwrite a previously customized drive rom.

Fixing the rom loading system which will solve that is right at the top of my todo list. Having separately loadable roms works fine for the C64 core, but the C128 has so many different roms we need something smarter.

User avatar
NML32
Posts: 288
Joined: Sun May 24, 2020 6:57 pm
Has thanked: 272 times
Been thanked: 43 times

Re: Commodore 128 for the MiSTer?

Unread post by NML32 »

eriks5 wrote: Sat Jan 21, 2023 2:01 pm

New development/test release of the C128 core is here!

Eye of the Beholder's second screen now works. And if you want to see the core's VDC implementation really shine, try this demo: Risen from Oblivion VDC V2

Thank you for the update. :)
I'm unsure what I'm doing wrong when trying to get dual screens working in Eye of the Beholder. My main screen is connected via HDMI, and my secondary screen is connected via the analog port to my PVM. Currently, both screens either show the game or the Map screen.

eriks5
Core Developer
Posts: 79
Joined: Sat May 21, 2022 11:51 am
Has thanked: 38 times
Been thanked: 182 times
Contact:

Re: Commodore 128 for the MiSTer?

Unread post by eriks5 »

NML32 wrote: Mon Jan 23, 2023 1:35 pm

I'm unsure what I'm doing wrong when trying to get dual screens working in Eye of the Beholder. My main screen is connected via HDMI, and my secondary screen is connected via the analog port to my PVM. Currently, both screens either show the game or the Map screen.

You're not doing anything wrong, you have to switch the screens. Dual screen output from the MiSTer isn't supported. It would probably need two instances of the scaler etc. Maybe it's possible, but it won't be easy to do so looking into that is very low on my todo list, since it's really only used by two games at the moment and for both the output on the VDC is more of a gimmick than useful.

Malor
Top Contributor
Posts: 860
Joined: Wed Feb 09, 2022 11:50 pm
Has thanked: 64 times
Been thanked: 194 times

Re: Commodore 128 for the MiSTer?

Unread post by Malor »

I think the dual screen thing was used quite a bit for development work, but almost everyone nowadays would write code on a PC and then cross-compile. It was a very popular feature then, but largely irrelevant to modern use cases.

Sw1tch73ch
Posts: 9
Joined: Mon Jul 25, 2022 1:59 am
Has thanked: 1 time

Re: Commodore 128 for the MiSTer?

Unread post by Sw1tch73ch »

I'm having an odd issue. I see people talking about the D71 / G71 format disks, but when I try to mount a disk (using F12 for the system options) I see "Mount #8 *.D64,G64,T64, D81" - there isn't a D71 / G71 there, so when I go to the folder I dropped all my *.D71 images, none show up because they aren't in the filter. Is there a way I can add D71? Is it part of the boot roms or something in the ini for the C128?

eriks5
Core Developer
Posts: 79
Joined: Sat May 21, 2022 11:51 am
Has thanked: 38 times
Been thanked: 182 times
Contact:

Re: Commodore 128 for the MiSTer?

Unread post by eriks5 »

Sw1tch73ch wrote: Thu Feb 23, 2023 5:26 am

I'm having an odd issue. I see people talking about the D71 / G71 format disks, but when I try to mount a disk (using F12 for the system options) I see "Mount #8 *.D64,G64,T64, D81" - there isn't a D71 / G71 there, so when I go to the folder I dropped all my *.D71 images, none show up because they aren't in the filter. Is there a way I can add D71? Is it part of the boot roms or something in the ini for the C128?

You are using an old version of the core that doesn't have the 1571 yet (I'm guessing 20220625). The latest dev release is 20230121 and can be downloaded from a few posts back in this topic.

tomxp411
Posts: 13
Joined: Fri Jul 17, 2020 4:32 am
Has thanked: 2 times
Been thanked: 1 time

Re: Commodore 128 for the MiSTer?

Unread post by tomxp411 »

eriks5 wrote: Thu Feb 23, 2023 7:16 am
Sw1tch73ch wrote: Thu Feb 23, 2023 5:26 am

I'm having an odd issue. I see people talking about the D71 / G71 format disks, but when I try to mount a disk (using F12 for the system options) I see "Mount #8 *.D64,G64,T64, D81" - there isn't a D71 / G71 there, so when I go to the folder I dropped all my *.D71 images, none show up because they aren't in the filter. Is there a way I can add D71? Is it part of the boot roms or something in the ini for the C128?

You are using an old version of the core that doesn't have the 1571 yet (I'm guessing 20220625). The latest dev release is 20230121 and can be downloaded from a few posts back in this topic.

I see there's a new main MiSTer update that supports the C128 core. Is the same change as in that recent release? Does this eliminate the need to install the main MiSTer binary?

eriks5
Core Developer
Posts: 79
Joined: Sat May 21, 2022 11:51 am
Has thanked: 38 times
Been thanked: 182 times
Contact:

Re: Commodore 128 for the MiSTer?

Unread post by eriks5 »

tomxp411 wrote: Thu Feb 23, 2023 6:29 pm

I see there's a new main MiSTer update that supports the C128 core. Is the same change as in that recent release? Does this eliminate the need to install the main MiSTer binary?

Yes it is, and the core will be available from the updater soon too

Sw1tch73ch
Posts: 9
Joined: Mon Jul 25, 2022 1:59 am
Has thanked: 1 time

Re: Commodore 128 for the MiSTer?

Unread post by Sw1tch73ch »

eriks5 wrote: Thu Feb 23, 2023 7:16 am
Sw1tch73ch wrote: Thu Feb 23, 2023 5:26 am

I'm having an odd issue. I see people talking about the D71 / G71 format disks, but when I try to mount a disk (using F12 for the system options) I see "Mount #8 *.D64,G64,T64, D81" - there isn't a D71 / G71 there, so when I go to the folder I dropped all my *.D71 images, none show up because they aren't in the filter. Is there a way I can add D71? Is it part of the boot roms or something in the ini for the C128?

You are using an old version of the core that doesn't have the 1571 yet (I'm guessing 20220625). The latest dev release is 20230121 and can be downloaded from a few posts back in this topic.

Thanks - I'll go grab that. I thought I'd grabbed the latest as I'd only grabbed it a week ago, give or take a few days. I'll look specifically for the 20230121 date. I've been having fun nostalgia with it so far, just rummaging through BASIC 7.0.

eriks5
Core Developer
Posts: 79
Joined: Sat May 21, 2022 11:51 am
Has thanked: 38 times
Been thanked: 182 times
Contact:

Re: Commodore 128 for the MiSTer?

Unread post by eriks5 »

It's released! The core will be downloaded by the updater script when you run it.

See the post in the updates and changelog forum for the full announcement.

rhester72
Top Contributor
Posts: 1101
Joined: Thu Jun 11, 2020 2:31 am
Has thanked: 13 times
Been thanked: 169 times

Re: Commodore 128 for the MiSTer?

Unread post by rhester72 »

@eriks5 MUCH congratulations is in order! Thank you so much for your effort on this!

User avatar
ron
Posts: 158
Joined: Sun May 24, 2020 7:02 pm
Has thanked: 65 times
Been thanked: 58 times

Re: Commodore 128 for the MiSTer?

Unread post by ron »

@eriks5 thanks very much !

jca
Top Contributor
Posts: 1911
Joined: Wed May 27, 2020 1:59 pm
Has thanked: 145 times
Been thanked: 454 times

Re: Commodore 128 for the MiSTer?

Unread post by jca »

Update all does not grab the core. Does the presence of a mra folder confuse the script?

Post Reply